Skip to content

Fixes "similar-code" issue in sendgrid/helpers/mail/mail.py#510

Closed
nanspro wants to merge 1 commit intosendgrid:masterfrom
nanspro:master
Closed

Fixes "similar-code" issue in sendgrid/helpers/mail/mail.py#510
nanspro wants to merge 1 commit intosendgrid:masterfrom
nanspro:master

Conversation

@nanspro
Copy link
Copy Markdown

@nanspro nanspro commented Oct 30, 2017 •
edited
Loading

Fixes #503

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This PR resolves the "similar-code" issue in sendgrid/helpers/mail/mail.py

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Nov 2, 2017

@nanspro

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Feb 27, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Jul 25, 2018

Thanks again for helping improve this SDK!

We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix "similar-code" issue in sendgrid/helpers/mail/mail.py

3 participants

@nanspro @thinkingserious @apigirl